Open
Conversation
knightsforce
changed the title
# Conflicts: # lib/di/di.config.dart
# Conflicts: # lib/app/view/app_model.dart # lib/di/di.config.dart # pubspec.lock # pubspec.yaml
… feature/EWM-617-check_root # Conflicts: # packages/ui_components_lib/lib/v2/colors_v2.dart
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements root/jailbreak detection functionality for the SparX Wallet Flutter application. When the app detects a rooted or jailbroken device, it displays a warning screen requiring the user to acknowledge the security risks before proceeding.
Changes:
- Added root/jailbreak detection using the
root_checker_pluspackage - Implemented a new alert screen with UI to warn users about security risks
- Refactored bootstrap navigation logic into a dedicated delegate class
- Introduced
IndependentSeedRouteinterface to allow certain routes (onboarding, root alert) to bypass seed-based guards
Reviewed changes
Copilot reviewed 18 out of 25 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
pubspec.yaml |
Added root_checker_plus: 1.0.0 dependency and new image asset directory |
pubspec.lock |
Lock file update for new dependency |
packages/ui_components_lib/lib/v2/colors_v2.dart |
Added white48 color constant for UI elements |
lib/generated/locale_keys.g.dart |
Generated locale keys for root detection strings |
lib/generated/assets.gen.dart |
Generated asset references for lock background image |
lib/feature/root_device_alert/view/widgets/root_device_info_bs.dart |
Bottom sheet widget explaining root/jailbreak risks |
lib/feature/root_device_alert/view/root_device_alert_screen_wm.dart |
Widget model for root alert screen state management |
lib/feature/root_device_alert/view/root_device_alert_screen_model.dart |
Elementary model connecting to services |
lib/feature/root_device_alert/view/root_device_alert_screen.dart |
Main root detection alert screen UI |
lib/feature/root_device_alert/route.dart |
Route configuration for root alert screen |
lib/feature/root_device_alert/domain/root_device_service.dart |
Service implementing root detection and user acknowledgment storage |
lib/di/di.config.dart |
Generated DI configuration for new services and routes |
lib/app/view/app_wm.dart |
Simplified navigation logic, delegating to new bootstrap delegate |
lib/app/view/app_model.dart |
Added root device service integration |
lib/app/service/bootstrap/bootstrap_navigation_delegate.dart |
New delegate extracting bootstrap navigation logic |
lib/app/router/compass/route.dart |
Added IndependentSeedRoute marker interface |
lib/feature/onboarding/route.dart |
Implemented IndependentSeedRoute for onboarding |
lib/feature/onboarding/guard.dart |
Updated guard to check IndependentSeedRoute instead of specific route type |
docs/theme_system.md |
Fixed documentation typo (DimensSizeV2 → DimensSize) |
assets/translations/en.json |
Added English translations for root detection messages |
assets/translations/ko.json |
Added Korean translations for root detection messages |
assets/images/lock_bg/lock.webp |
Background image for root alert screen |
lib/feature/root_device_alert/view/root_device_alert_screen.dart
Outdated
Show resolved
Hide resolved
lib/feature/root_device_alert/view/root_device_alert_screen.dart
Outdated
Show resolved
Hide resolved
lib/feature/root_device_alert/view/root_device_alert_screen.dart
Outdated
Show resolved
Hide resolved
lib/feature/root_device_alert/view/root_device_alert_screen_model.dart
Outdated
Show resolved
Hide resolved
lib/feature/root_device_alert/view/root_device_alert_screen.dart
Outdated
Show resolved
Hide resolved
# Conflicts: # packages/ui_components_lib/lib/v2/colors_v2.dart
Odrin
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change